Skip to content

eth/fetcher: minor refactor, fixes #23738 #23760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Oct 18, 2021

This PR should be functionally equivalent with the previous code, with the exception of removing a check on an impossible situation (err != nil followed by switch with err == nil)

@holiman holiman linked an issue Oct 18, 2021 that may be closed by this pull request
@holiman
Copy link
Contributor Author

holiman commented Oct 18, 2021

Closing in favour of #23739

@holiman holiman closed this Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth/fetcher fails nilness static analysis check
1 participant