eth/fetcher: Remove unnecessary error check to satisfy static analysis #23739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
requested review from
holiman,
karalabe and
rjl493456442
as code owners
prestonvanloon
force-pushed
the
fix-nilness-check
branch
from
c641156 to
4db8f1c
Compare
prestonvanloon
commented
Oct 14, 2021
| @@ -277,29 +277,27 @@ func (f *TxFetcher) Enqueue(peer string, txs []*types.Transaction, direct bool) | |||
| ) | |||
| errs := f.addTxs(txs) | |||
| for i, err := range errs { | |||
| if err != nil { | |||
There was a problem hiding this comment.
This if err != nil was bothering the nilness analysis check and is safe to remove.
jwasinger
approved these changes
Oct 15, 2021
|
Sorry, I didn't notice that you had made this PR, so I made one myself too |
|
While we're fixing the code, it would be good to remove explicit error checks, and use |
@holiman I've done this now. Please take a look! |
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Oct 20, 2021
* eth/fetcher: fix nilness check ethereum#23738 * eth/fetcher: Use errors.Is. PR feedback from @holiman.
yongjun925
pushed a commit
to DODOEX/go-ethereum
that referenced
this pull request
Dec 3, 2022
* eth/fetcher: fix nilness check ethereum#23738 * eth/fetcher: Use errors.Is. PR feedback from @holiman.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23738. See #23738 for more context on the nilness analysis check issue.