Skip to content

rpc: cancel root context after all requests are served #19430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2019
Merged

rpc: cancel root context after all requests are served #19430

merged 1 commit into from
Apr 10, 2019

Conversation

rjl493456442
Copy link
Member

@rjl493456442 rjl493456442 commented Apr 10, 2019 •
edited
Loading

@rjl493456442 rjl493456442 requested a review from fjl April 10, 2019 04:19
@rjl493456442 rjl493456442 mentioned this pull request Apr 10, 2019
Closed
karalabe
karalabe approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe merged commit e4cb7b8 into ethereum:master Apr 10, 2019
@karalabe karalabe added this to the 1.9.0 milestone Apr 10, 2019
@AusIV AusIV mentioned this pull request Jan 20, 2020
Open
@JayChoi1736 JayChoi1736 mentioned this pull request Sep 13, 2022
Closed
9 tasks
@JayChoi1736 JayChoi1736 mentioned this pull request Oct 28, 2022
Merged
9 tasks
@trinhdn2 trinhdn2 mentioned this pull request Dec 8, 2023
Closed
1 task
@fjl fjl mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjl fjl Awaiting requested review from fjl fjl is a code owner

1 more reviewer

@karalabe karalabe karalabe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@rjl493456442 @karalabe