Deprecate NakedButton component #9519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace with Chakra components
wackerow
requested review from
corwintines,
jmcook1186,
minimalsm,
pettinarip and
samajammin
as code owners
github-actions
bot
added
content 🖋️
✅ ethereum-org-website-dev deploy preview ready
|
pettinarip
approved these changes
Feb 20, 2023
Member
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
Awesome! nicely done @wackerow
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NakedButtoncomponent, and replace with use of Chakra componentsIconButtonfor icons used as buttons without any textcommon.jsonfor aria labelrun-a-nodepageRelated Issue