Migrate the BoxGrid component to Chakra
#9094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
corwintines,
jmcook1186,
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
TylerAPfledderer
suggested changes
Jan 8, 2023
Contributor
TylerAPfledderer
left a comment
TylerAPfledderer
left a comment
There was a problem hiding this comment.
Hey @soheil555! Nice work here. 🤘🏼
For you and @pettinarip, I've provided some thoughts with using SimpleGrid to keep from flipping between grid and flexbox, along with tricks to simplify the code. Wondering from both of you if these suggested changes improve readability. 😄
Author
|
Hey @TylerAPfledderer |
pettinarip
requested changes
Jan 18, 2023
Member
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
Thanks @soheil555, the component is working perfectly for me 💯
Would like to see the SimpleGrid implementation here if that is possible.
Thanks @TylerAPfledderer for the suggestions and review 💪🏼
Co-authored-by: Tyler Pfledderer <[email protected]>
ghost
requested review from
pettinarip
and removed request for
TylerAPfledderer
80 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate the
BoxGridcomponent to ChakraRelated Issue
#8632