Breadcrumbs.tsx Refactor #8641
Breadcrumbs.tsx Refactor #8641
Conversation
beamandala
requested review from
corwintines,
jmcook1186,
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
There was a problem hiding this comment.
Hey @master7130!
Nice PR here, I have left only one comment with the changes you have made. 😄
However, I believe this component can use Charka's BreadCrumb multi-component and retain this component to provide additional needed logic.
The only tiny gotcha from what I can see is that the Chakra version currently deployed in this project is not up-to-date and therefore the BreadCrumb will not have the listProps prop for immediate access to the list element rendered for styling. So the workaround would be the following to get rid of the left margin from the global styles:
<BreadCrumb
sx={{
ms: 0
}}
/>I would also like @pettinarip's feedback on this recommendation.
|
Good suggestion @TylerAPfledderer. I agree with you, we should use the Chakra's component. However, I think we can merge this PR for now. I've created a new issue to tackle the replacement. I haven't assigned anyone yet. Please, leave a comment on the issue if someone is interested in working on that. Thanks 🙏🏼 |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
3 participants
Description
Refactored Breadcrumbs.tsx from styled components to ChakraUI.
Related Issue
#6374