Skip to content

Fixed reset issue in sub-filters #8171 #8291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2022
Merged

Fixed reset issue in sub-filters #8171 #8291

merged 2 commits into from
Oct 31, 2022

Conversation

@ankitzm
Copy link
Contributor

@ankitzm ankitzm commented Oct 19, 2022 •
edited
Loading

Description

Filters having sub-filters doesn't reset after clicking the reset button.
Fixing issue #8171

Changes made

  • Added a new function to reset filters to the default values(false and undefined)
  • New function added to child component - WalletFilterSidebar.tsx
  • Called reset function in Reset container in find-wallet.tsx
  • Tested all possible ways to reset filters.

Fixed Version

Screencast.from.19-10-22.01.03.19.PM.IST.webm

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 labels Oct 19, 2022
@ankitzm ankitzm mentioned this pull request Oct 19, 2022
Closed
@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 19, 2022

✅ ethereum-org-website-dev deploy preview ready

@ankitzm
Copy link
Contributor Author

ankitzm commented Oct 23, 2022

Hey @samajammin, @wackerow, @corwintines, @pettinarip, @minimalsm, @jmcook1186
Can you please review !!

corwintines
corwintines approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@corwintines corwintines left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @ankitzm!

Definitely think this whole section of the site could use some TLC in refactoring the filters logic to make it more simple, but this works well for now!

Be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. We also have our 2022 POAPs so remember to claim yours 🥳!

@corwintines
Copy link
Member

@all-contributors can you add @ankitzm for code

@allcontributors allcontributors bot mentioned this pull request Oct 31, 2022
Merged
@allcontributors
Copy link
Contributor

@corwintines

I've put up a pull request to add @ankitzm! 🎉

@corwintines corwintines merged commit 1ed650c into ethereum:dev Oct 31, 2022
@gitpoap-bot
Copy link

gitpoap-bot bot commented Oct 31, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Ethereum.org Contributor:

GitPOAP: 2022 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@corwintines corwintines mentioned this pull request Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corwintines corwintines corwintines approved these changes

@samajammin samajammin Awaiting requested review from samajammin

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

@jmcook1186 jmcook1186 Awaiting requested review from jmcook1186

Assignees

No one assigned

Labels

content 🖋️ This involves copy additions or edits

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ankitzm @corwintines