Skip to content

Conversation

@giorgionocera
Copy link
Contributor

Fix subtitles wrong formating

Description

With this commit (and consequently PR), we are removing links for the h5 heading (in pages that are using them) since the markdown converter does not support them.

Related Issue

Fixes #8168

Fixing the issue ethereum#8168 removing links for h5 heading since the markdown converter do not support them.
@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 translation 🌍 This is related to our Translation Program labels Oct 11, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 11, 2022

✅ ethereum-org-website-dev deploy preview ready

```


#### Running an execution client {#running-an-execution-client}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Running an execution client {#running-an-execution-client}
#### Running an execution client

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review @vj-codes!
Since this one is an h4 heading, it can be converted by the markdown parser (e.g., https://ethereum.org/en/developers/docs/nodes-and-clients/run-a-node/#running-an-execution-client).

Are you sure we need to change also this one?

Copy link
Contributor

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one too

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @giorgionocera!

Be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. We also have our 2022 POAPs so remember to claim yours 🥳!

@corwintines
Copy link
Member

@all-contributors can you add @giorgionocera for doc

@allcontributors
Copy link
Contributor

@corwintines

I've put up a pull request to add @giorgionocera! 🎉

@corwintines corwintines merged commit 1978dd9 into ethereum:dev Oct 31, 2022
@gitpoap-bot
Copy link

gitpoap-bot bot commented Oct 31, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Ethereum.org Contributor:

GitPOAP: 2022 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@corwintines corwintines mentioned this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong formating in run a node page

3 participants