- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5.3k
style(docs and tutorials): 🔥 fix issue ethereum/ethereum-org-web… #8234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(docs and tutorials): 🔥 fix issue ethereum/ethereum-org-web… #8234
Conversation
Fixing the issue ethereum#8168 removing links for h5 heading since the markdown converter do not support them.
| ✅ ethereum-org-website-dev deploy preview ready
 | 
| ``` | ||
|  | ||
|  | ||
| #### Running an execution client {#running-an-execution-client} | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| #### Running an execution client {#running-an-execution-client} | |
| #### Running an execution client | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your review @vj-codes!
Since this one is an h4 heading, it can be converted by the markdown parser (e.g., https://ethereum.org/en/developers/docs/nodes-and-clients/run-a-node/#running-an-execution-client).
Are you sure we need to change also this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @giorgionocera!
Be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. We also have our 2022 POAPs so remember to claim yours 🥳!
| @all-contributors can you add @giorgionocera for doc | 
| I've put up a pull request to add @giorgionocera! 🎉 | 
| Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. | 

Fix subtitles wrong formating
Description
With this commit (and consequently PR), we are removing links for the h5 heading (in pages that are using them) since the markdown converter does not support them.
Related Issue
Fixes #8168