Skip to content

Conversation

@malunem
Copy link
Contributor

@malunem malunem commented Oct 7, 2022

Migrate Checkbox to Chakra Native Component

Description

Related Issue

#6374

@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 7, 2022

✅ ethereum-org-website-dev deploy preview ready

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work on this @marcellamalune. Thanks so much for this PR. I left a few comments to cleanup the old props and logic we had before. The rest is great.

@malunem
Copy link
Contributor Author

malunem commented Oct 13, 2022

@pettinarip thank you for your feedbacks! I applied all your suggestions.

@malunem malunem requested a review from pettinarip October 13, 2022 19:07
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @marcellamalune! 🎉 I've just added some cleanup stuff. Will merge it soon.

@pettinarip pettinarip merged commit b10af35 into ethereum:dev Oct 19, 2022
@corwintines corwintines mentioned this pull request Oct 21, 2022
@pettinarip pettinarip mentioned this pull request Oct 25, 2022
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

archived: chakra-migration content 🖋️ This involves copy additions or edits

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants