Migrate UpgradeStatus.tsx to Chakra UI
#8195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jb-0
requested review from
corwintines,
jmcook1186,
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
jb-0
changed the title
UpgradeStatus.tsx to Chakra UI
✅ ethereum-org-website-dev deploy preview ready
|
pettinarip
requested changes
Oct 10, 2022
Co-authored-by: Pablo Pettinari <[email protected]>
…jb-0/ethereum-org-website into refactor/migrate_upgrade_status
pettinarip
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Awesome @jb-0 thanks for the detailed PR (with all the screenshots) 👍🏼
re: the isShipped flag, thats ok. It is an optional flag, so if it is not present then it defaults to false.
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
|
@jb-0 be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. And we've just released our 2022 POAPs so remember to claim yours also 🥳! |
|
@all-contributors please add @jb-0 for code |
|
I've put up a pull request to add @jb-0! 🎉 |
80 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the Upgrade Status component to Chakra UI.
Side note: it seems the
isShippedflag is missing from the following file:src/content/upgrades/merge/index.mdRelated Issue
#6374
Screenshots