Refactor of DataProductCard to Chakra #8015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuisUrrutia
requested review from
corwintines,
jmcook1186,
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
pettinarip
requested changes
Sep 28, 2022
There was a problem hiding this comment.
Great job overall @LuisUrrutia ty for the PR. I think we should use LinkOverlay to wrap the component.
pettinarip
reviewed
Oct 6, 2022
pettinarip
approved these changes
Oct 6, 2022
There was a problem hiding this comment.
Great job @LuisUrrutia thanks for implementing the LinkOverlay correctly 👍🏼
I did a few tiny changes to use the chakra scale in paddings and margins.
pettinarip
reviewed
Oct 10, 2022
pettinarip
reviewed
Oct 10, 2022
80 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates
DataProductCardcomponent fromemotiontochakra-ui.Related Issue
#6374