-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Deprecate InfoBanner, migrate usage to ui/alert
components
#13986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update all `<InfoBanner shouldSpaceBetween emoji=":eyes:">{children}</InfoBanner>` instances to use `<Alert className="justify-between"><AlertEmoji text=":eyes:" />{children}</Alert>`
Convert all `<InfoBanner emoji="text">` to `<Alert><AlertEmoji text="text"/><AlertContent>`
Migrate all isWarning to variant="warning"
Migrate all vanilla `<InfoBanner>` instances to ui/alert
Previous `InfoBanner` components with `isWarning` flag initially migrated with `warning` variant, which is yellow, but should be red: switched to `error` variant to match
all instances with mb-8 and title
update all `<InfoBanner mb={8}` instances
update all `<InfoBanner isWarning>` instances
migrate all `<InfoBanner isWarning mb={8}>` instances
migrate all `<InfoBanner shouldCenter emoji=` instances
migrate all `<InfoBanner shouldSpaceBetween emoji="" mt="8">` instances
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Switching to "Ready for review" to get eyes 👀 on this, but leaving as "Work In Progress" for at least a few days while we comb through this... touches hundreds of files, so let's make sure we've done plenty of QA checking on this. |
Another one centered And this tag... it hurts my eyes |
there is a dot on the third line |
Agree we should fix this... Imo this shouldn't be done as a default Alert styling though. I'd like to handle this from the parent in a separate PR. The spacing here shines light on our |
Played around with this... given it's current setup, and the complexity of this PR already, let's table to a separate task/PR. |
ui/alert
components
Juicy and unfortunate merge conflict with the latest translation import... will need to find time to go through this |
This issue is stale because it has been open 30 days with no activity. |
Closing due to complexity of merge conflicts; will likely be simpler to start fresh. Issue posted #15407; this branch can be used in whatever capacity as a reference for future implementation |
Description
ui/alert
with modifications to theming per latest design systemAlertEmoji
toui/alert
, with default styling matching the oldEmoji
portion of theInfoBanner
componentInfoBanner
to useAlert
component structure instead.EnvWarningBanner
to useui/alert
. A few markdown pages had the manual addition of effectively the same component as theEnvWarningBanner
component, so this was removed and replaced with the component (now included inMdComponents
).Related Issue
shadcn migration and theming updates