Updates "what is ethereum" page #10572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcook1186
added
content 🖋️
jmcook1186
requested review from
corwintines,
minimalsm,
nhsz,
pettinarip,
samajammin and
wackerow
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
wackerow
reviewed
Jun 28, 2023
Member
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
Awesome job! This is looking a lot better... left a handful of small suggestions =)
corwintines
reviewed
Jun 29, 2023
Member
corwintines
left a comment
corwintines
left a comment
There was a problem hiding this comment.
Awesome job @jmcook1186!
I have one suggestion to add here as well in addition to @wackerow. Overall, great though.
Co-authored-by: Paul Wackerow <[email protected]> Co-authored-by: Corwin Smith <[email protected]>
corwintines
approved these changes
Jun 29, 2023
This was referenced Jul 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the
learn/what-is-ethereumpage by amending some copy and rearranging existing sections into a more logical order. Based on feedback that the current page wasn't adequately explaining the most important concepts. Also fixes unit error in one of the quiz questions.Preview
https://ethereumorgwebsitedev01-whatisethereum.gatsbyjs.io/en/what-is-ethereum