Skip to content

change(MD5Builder): Const-correctness. #9104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2024
Merged

change(MD5Builder): Const-correctness. #9104

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ff8c52
change(HashBuilder): Const-correctness
StefanOberhumer Jan 14, 2024
509df6d
Remove char* methods
lucasssvaz Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cores/esp32/HashBuilder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ class HashBuilder : public HEXBuilder
virtual ~HashBuilder() {}
virtual void begin() = 0;

virtual void add(uint8_t* data, size_t len) = 0;
virtual void add(const uint8_t* data, size_t len) = 0;
virtual void add(const char* data)
{
add((uint8_t*)data, strlen(data));
add((const uint8_t*)data, strlen(data));
}
virtual void add(char* data)
{
Expand Down
2 changes: 1 addition & 1 deletion cores/esp32/MD5Builder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ void MD5Builder::begin(void)
esp_rom_md5_init(&_ctx);
}

void MD5Builder::add(uint8_t * data, size_t len)
void MD5Builder::add(const uint8_t * data, size_t len)
{
esp_rom_md5_update(&_ctx, data, len);
}
Expand Down
2 changes: 1 addition & 1 deletion cores/esp32/MD5Builder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class MD5Builder : public HashBuilder
void begin(void) override;

using HashBuilder::add;
void add(uint8_t * data, size_t len) override;
void add(const uint8_t * data, size_t len) override;

using HashBuilder::addHexString;
void addHexString(const char * data) override;
Expand Down
2 changes: 1 addition & 1 deletion cores/esp32/SHA1Builder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ void SHA1Builder::begin(void)
memset(hash, 0x00, sizeof(hash));
}

void SHA1Builder::add(uint8_t* data, size_t len)
void SHA1Builder::add(const uint8_t* data, size_t len)
{
size_t fill;
uint32_t left;
Expand Down
2 changes: 1 addition & 1 deletion cores/esp32/SHA1Builder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class SHA1Builder : public HashBuilder
void begin() override;

using HashBuilder::add;
void add(uint8_t* data, size_t len) override;
void add(const uint8_t* data, size_t len) override;

using HashBuilder::addHexString;
void addHexString(const char* data) override;
Expand Down