Skip to content

Conversation

mariopesch
Copy link
Contributor

@mariopesch mariopesch commented Nov 16, 2023

Description of Change

Adds a new variant directory for senseBox MCU-S2 with ESP32S2. TinyUF2 boot loader is included (see: adafruit/tinyuf2#360) Add sensebox_mcu_esp32s2 in boards.txt

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.
Tested with Arduino-ESP32 Core v2.0.14

Related links

Website: https://sensebox.de/

Allocation for PID under Espressif VID used in this PR: espressif/usb-pids#121

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

@P-R-O-C-H-Y P-R-O-C-H-Y added the Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. label Nov 16, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y self-requested a review November 16, 2023 15:46
@P-R-O-C-H-Y
Copy link
Member

@mariopesch can you please update your branch with the latest master? Thanks

@mariopesch
Copy link
Contributor Author

@P-R-O-C-H-Y sure! Done ✔️

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariopesch PTAL on my comments.

@mariopesch
Copy link
Contributor Author

@P-R-O-C-H-Y thanks for the review. Just commited the changes

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now. LGTM

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Nov 22, 2023
@me-no-dev
Copy link
Member

please fix the conflicts. It was caused by an earlier PR that also added a board

@mariopesch
Copy link
Contributor Author

@me-no-dev conflict should be resolved now

@me-no-dev me-no-dev merged commit bb72b02 into espressif:master Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants