Skip to content

Add new uPesy boards as variant #8778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Oct 24, 2023
Merged

Add new uPesy boards as variant #8778

merged 20 commits into from
Oct 24, 2023

Conversation

uPesy
Copy link
Contributor

@uPesy uPesy commented Oct 17, 2023

Description of Change

Add new uPesy ESP32 based devkit board in variant folder and in boards.txt :

  • uPesy ESP32 EDU
  • uPesy ESP32C3 Basic
  • uPesy ESP32C3 Mini
  • uPesy ESP32S3 Basic

Tests scenarios

  • Test on physical boards with latest version of arduino-esp32

Related links

(eg. Closes #number of issue)

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Jason2866
Copy link
Collaborator

Look at existing boards. The way it is done has changed. You have to remove some not anymore needed entrys.

atanisoft
atanisoft reviewed Oct 17, 2023
View reviewed changes
variants/uPesy_edu_esp32/pins_arduino.h Outdated

#define analogInputToDigitalPin(p) (((p)<20)?(analogChannelToDigitalPin(p)):-1)
#define digitalPinToInterrupt(p) (((p)<40)?(p):-1)
#define digitalPinHasPWM(p) (p < 34)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the above defines (lines 7-13) are no longer required and will be automatically provided by the base platform.

variants/uPesy_esp32c3_basic/pins_arduino.h Outdated

#define analogInputToDigitalPin(p) (((p)<NUM_ANALOG_INPUTS)?(analogChannelToDigitalPin(p)):-1)
#define digitalPinToInterrupt(p) (((p)<NUM_DIGITAL_PINS)?(p):-1)
#define digitalPinHasPWM(p) (p < EXTERNAL_NUM_INTERRUPTS)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the above defines (lines 23-18) are no longer required and will be automatically provided by the base platform.

@P-R-O-C-H-Y P-R-O-C-H-Y added the Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. label Oct 18, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y self-requested a review October 18, 2023 07:19
@uPesy
Copy link
Contributor Author

uPesy commented Oct 18, 2023

I don't understand why there is this error for each board:

 /home/runner/Arduino/hardware/espressif/esp32/cores/esp32/esp32-hal-gpio.h:29:10: fatal error: pins_arduino.h: No such file or directory
     29 | #include "pins_arduino.h"
        |          ^~~~~~~~~~~~~~~~

P-R-O-C-H-Y
P-R-O-C-H-Y requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uPesy PTAL on my comments. Thanks

@uPesy
Copy link
Contributor Author

uPesy commented Oct 18, 2023

It should be fine now

P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uPesy Looks good now :) Lets wait for CI to pass and can be merged ;)

uPesy
uPesy commented Oct 18, 2023
View reviewed changes
Copy link
Contributor Author

@uPesy uPesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine now

P-R-O-C-H-Y
P-R-O-C-H-Y reviewed Oct 18, 2023
View reviewed changes
@P-R-O-C-H-Y P-R-O-C-H-Y self-requested a review October 18, 2023 09:29
@uPesy
Copy link
Contributor Author

uPesy commented Oct 23, 2023

@P-R-O-C-H-Y I have correctly renamed the lines. Sorry for this small mistakes

@uPesy
Copy link
Contributor Author

uPesy commented Oct 24, 2023

@P-R-O-C-H-Y I have fixed the mistakes.

P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged now :)

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Resolution: Awaiting response labels Oct 24, 2023
@me-no-dev me-no-dev merged commit a04f351 into espressif:master Oct 24, 2023
@uPesy uPesy mentioned this pull request Dec 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

+1 more reviewer

@atanisoft atanisoft atanisoft left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@uPesy @CLAassistant @Jason2866 @atanisoft @P-R-O-C-H-Y @me-no-dev