HardwareSerial::end(bool) review + Baud Rate detection review and example #8762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuGlider
added
the
Peripheral: UART
lucasssvaz
approved these changes
Oct 16, 2023
Member
lucasssvaz
left a comment
lucasssvaz
left a comment
There was a problem hiding this comment.
LGTM, thanks for the changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR removes UART pins detaching whenever it is used to detect baud rate.
Such feature only works with ESP32 and ESP32-S2.
It also fixes error message when trying to use ESP32-S3, ESP32-C3, ESP32-C6 and ESP32-H2 with baud rate detection.
In addition the PR also add an example about how to use baud rate detection feature.
Tests scenarios
Tested with ESP32 and ESP32-S2 UART0 using the Example provided in this PR.
Related links
None