add 'NO_GLOBAL_UPDATE' define to disable global UpdateClass instance #8500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stance Save 180 bytes of ram if UpdateClass instance is not required
|
|
vortigont
added a commit
to vortigont/FireLamp_JeeUI
that referenced
this pull request
Sep 22, 2023
would save 180 bytes on Updater class instance espressif/arduino-esp32#8500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves 180 bytes of RAM if UpdateClass instance is not required in project
follows same semantics as for
NO_GLOBAL_HTTPUPDATENO_GLOBAL_ARDUINOOTAP.S. I could come up with PR for refactored
UpdateClasswhereMD5Builder _md5member is created on-demand allocating from a heap for the duration of update. Could save about 100 bytes for global UpdateClass instance. but I'm not sure it worth the efforts and would be accepted. Let me know.