Skip to content

Conversation

strid3r21
Copy link
Contributor

added Bee Data Logger board (esp32s3)

testing in 2.0.7 and works as intended.

strid3r21 and others added 5 commits August 17, 2022 04:15
somehow had duplicated the same name across all my boards. the PID's and VID's were correct, but the name was the same for all of them. that is fixed now.
@me-no-dev me-no-dev requested a review from P-R-O-C-H-Y March 31, 2023 10:41
@atanisoft atanisoft added the Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. label Mar 31, 2023
@P-R-O-C-H-Y
Copy link
Member

Hi @strid3r21 Can you provide any data-sheet or docs to the board you want to add?

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good and can be merged.

@strid3r21
Copy link
Contributor Author

Hi @strid3r21 Can you provide any data-sheet or docs to the board you want to add?

@P-R-O-C-H-Y
https://github.com/strid3r21/Bee-Data-Logger is the github repo.

@atanisoft the wrong board name should be fixed.

@atanisoft
Copy link
Collaborator

the wrong board name should be fixed.

Not quite, it need to be all upper case.

@strid3r21
Copy link
Contributor Author

the wrong board name should be fixed.

Not quite, it need to be all upper case.

fixed. is this a new requirement? my other boards ive added before didn't have all upper case names

@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commented Apr 3, 2023

the wrong board name should be fixed.

Not quite, it need to be all upper case.

fixed. is this a new requirement? my other boards ive added before didn't have all upper case names

There is a PR #7942 about that which will be merged probably soon. I did review of your PR before I got to mentioned PR so thanks @atanisoft for pointing that out.

@atanisoft
Copy link
Collaborator

fixed.

Thanks.

is this a new requirement? my other boards ive added before didn't have all upper case names

Not specifically a new requirement, but there is a pending PR to move all existing boards to upper case since this ends up used as a precompiler definition which typically are always upper case (as are all other ones from this repos)

@strid3r21
Copy link
Contributor Author

fixed.

Thanks.

is this a new requirement? my other boards ive added before didn't have all upper case names

Not specifically a new requirement, but there is a pending PR to move all existing boards to upper case since this ends up used as a precompiler definition which typically are always upper case (as are all other ones from this repos)

good to know! thanks guys!

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Apr 4, 2023
@me-no-dev me-no-dev merged commit 3f679e8 into espressif:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants