Skip to content

Add the Partition Scheme Menu to HELTEC LoRa32 V1 #7362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 3, 2022
Merged

Add the Partition Scheme Menu to HELTEC LoRa32 V1 #7362

merged 5 commits into from
Nov 3, 2022

Conversation

@H3wastooshort
Copy link
Contributor

@H3wastooshort H3wastooshort commented Oct 15, 2022

This is missing from many boards, i may add that to all of them

@VojtechBartoska VojtechBartoska added the Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. label Oct 21, 2022
P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Hacker-3000, if you see some other boards with missing Partition Schemes, feel free to open another PR for that :) Thanks

@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commented Oct 24, 2022

@Hacker-3000 why did you reordered the partition schemes? Is there any reason for that?

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Oct 24, 2022
@H3wastooshort
Copy link
Contributor Author

H3wastooshort commented Oct 26, 2022 •
edited
Loading

i've done this to make sure the default option ist always auto-selected and to give a list from more user/newbie-friendly to less as this board is often used to build small and quick beginner projects involving LoRaWAN

@P-R-O-C-H-Y P-R-O-C-H-Y merged commit 999d094 into espressif:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@PilnyTomas PilnyTomas Awaiting requested review from PilnyTomas

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels

Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@H3wastooshort @P-R-O-C-H-Y @VojtechBartoska