Correct millis() error causes by micros() overflow every about 72 minutes #2438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everslick
added a commit
to everslick/Arduino-ESP32-1.0.0
that referenced
this pull request
Feb 20, 2019
millis() rollover bug espressif/arduino-esp32#2438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects issue #2430, thanks to @stickbreaker for the very easy solution found!
This solution is very different from the ESP8266 solution, because on that controller the micros() timer used to calculate millis() is a 32 bit wide counter. On the ESP32 the micros() base counter is 64 bits wide, allowing the solution to be both fast and simple. As I understand from reading topics on the internet, the division by 1,000 needed in this solution should be optimised by the gcc compiler using the same magic number method as in the ESP8266.
The new millis() function was tested (only) one loop of 72 minutes, without an issue.