Skip to content

Conversation

@facchinm
Copy link
Contributor

@facchinm facchinm commented Nov 5, 2025


Description of Change

This PR adds support for upcoming Arduino Nesso N1 board. The board is a boxed product, containing an ESP32-C6 module, a small display , a buzzer, QWIIK and GROVE connectors, a battery + its charger/fuel gauge and a LoRa SX1262 radio.

Most of the internal GPIOs are exposed via I2C expanders, so they have been described and added to a couple of extra files in variant folder.
If this is not advisable, let me know and I'll drop the last couple of commits, turning them into a library (this wouldn't be ideal since also LED_BUILTIN pin is on an expander).

Test Scenarios

We tested the board with:

hwConfig.CHIP_TYPE = SX1262_CHIP;
hwConfig.PIN_LORA_RESET = -1; // LORA RESET
hwConfig.PIN_LORA_NSS = LORA_CS;	  // LORA SPI CS
hwConfig.PIN_LORA_SCLK = SCK;	  // LORA SPI CLK
hwConfig.PIN_LORA_MISO = MISO;	  // LORA SPI MISO
hwConfig.PIN_LORA_DIO_1 = LORA_IRQ; // LORA DIO_1
hwConfig.PIN_LORA_BUSY = LORA_BUSY;	  // LORA SPI BUSY
hwConfig.PIN_LORA_MOSI = MOSI;	  // LORA SPI MOSI
hwConfig.RADIO_TXEN = -1;		  // LORA ANTENNA TX ENABLE
hwConfig.RADIO_RXEN = -1;		  // LORA ANTENNA RX ENABLE
hwConfig.USE_DIO2_ANT_SWITCH = true;
hwConfig.USE_DIO3_TCXO = true;
hwConfig.USE_DIO3_ANT_SWITCH = false;
hwConfig.USE_RXEN_ANT_PWR = true;

Related links

LInks will be added as soon as the product pages are up.

@facchinm facchinm requested a review from P-R-O-C-H-Y as a code owner November 5, 2025 14:06
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "feat: add Arduino Nesso N1":
    • footer must have leading blank line
    • footer's lines must not be longer than 100 characters

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello facchinm, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 914165a

@facchinm facchinm changed the title Add support for Arduino Nesso N1 feat(board): add support for Arduino Nesso N1 Nov 5, 2025
Also implement an oveload for digital* operation to abstract
the various gpio expanders.

TODO: change WireInternal into default Wire (will require the
user to explicitly include "Wire.h" (as in
https://github.com/arduino/ArduinoCore-mbed/blob/main/variants/NANO_RP2040_CONNECT/nina_pins.h#L14-L18
)
only charging for now
@P-R-O-C-H-Y P-R-O-C-H-Y added the Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. label Nov 5, 2025
@espressif espressif deleted a comment from lucasssvaz Nov 5, 2025
@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Nov 5, 2025
@github-actions github-actions bot added the Status: Pre-commit fixes required ⚠️ The pre-commit bot can't fix the issues automatically. Please fix the issues manually. label Nov 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

⚠️ Pre-commit Hooks Failed

Some pre-commit hooks failed and require manual fixes. Please see the detailed error report below.

What to do:

  1. 📋 View the detailed error report to see which hooks failed
  2. 🔧 Fix the issues locally in your code
  3. 💾 Commit and push your changes
  4. 🔄 The hooks will run again automatically

Need help? Ask in the comments below.


static bool readBitRegister(uint8_t address, uint8_t reg, uint8_t bit) {
uint8_t val = readRegister(address, reg);
return ((val & (1 << bit)) > 0);

Check warning

Code scanning / CodeQL

Sign check of bitwise operation Warning

Potentially unsafe sign check of a bitwise operation.
@github-actions github-actions bot removed the Status: Pre-commit fixes required ⚠️ The pre-commit bot can't fix the issues automatically. Please fix the issues manually. label Nov 5, 2025
@me-no-dev me-no-dev merged commit d1eb62d into espressif:master Nov 5, 2025
13 checks passed
@me-no-dev
Copy link
Member

@facchinm we have just released core version 3.3.3 that includes support for this board.

If you need to add similar support in the future, I suggest to use the I2C C API from esp32-hal-i2c.h, because it does not need any tricks, it's lightweight and most of all, is thread-safe. Wire.read() is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants