Skip to content

Add senseBox Eye board #11608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add senseBox Eye board #11608

wants to merge 9 commits into from
+344 −0

Conversation

PaulaScharf
Copy link
Contributor

Description of Change

Adding the senseBox Eye board.

Tests scenarios

I have tested this pull request on the senseBox Eye board.

Related links

@PaulaScharf PaulaScharf requested a review from P-R-O-C-H-Y as a code owner July 18, 2025 12:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello PaulaScharf, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 349b11d

lucasssvaz
lucasssvaz reviewed Jul 18, 2025
View reviewed changes
boards.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are deleting other users' boards. Please rebase your branch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PaulaScharf please fix this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry about that. I hope its good now

@lucasssvaz lucasssvaz added the Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. label Jul 18, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Awaiting Response awaiting a response from the author label Jul 18, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Review needed Issue or PR is awaiting review and removed Status: Awaiting Response awaiting a response from the author labels Jul 21, 2025
me-no-dev
me-no-dev reviewed Jul 21, 2025
View reviewed changes
variants/sensebox_eye/variant.cpp

extern "C" {

void blinkLED(uint8_t color[3], rmt_channel_handle_t led_chan, rmt_encoder_handle_t ws2812_encoder, rmt_transmit_config_t tx_config) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Arduino APIs for RMT and do not use ESP_ERROR_CHECK because it will abort in case of error and bootloop the device. We have ready-to-use APIs for controlling ws2812 (even as LED_BUILTIN). Have a look at those

P-R-O-C-H-Y
P-R-O-C-H-Y reviewed Jul 22, 2025
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @PaulaScharf just please change the rat code to use Arduino API as me-no-dev commented.

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Awaiting Response awaiting a response from the author and removed Status: Review needed Issue or PR is awaiting review labels Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev me-no-dev left review comments

@lucasssvaz lucasssvaz lucasssvaz left review comments

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y left review comments

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Status: Awaiting Response awaiting a response from the author Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PaulaScharf @me-no-dev @lucasssvaz @P-R-O-C-H-Y