-
Notifications
You must be signed in to change notification settings - Fork 7.8k
fix(eth): Set the ETH properties at the correct time #11182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello me-no-dev, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 12m 42s ⏱️ Results for commit 5c70f49. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
P-R-O-C-H-Y
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SuGlider
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request includes several changes to the
ETHClassin thelibraries/Ethernet/src/ETH.cppandlibraries/Ethernet/src/ETH.hfiles. The changes primarily focus on adding support for configuring Ethernet settings such as full duplex mode, link speed, and auto-negotiation, as well as ensuring these settings are properly managed during the Ethernet initialization and shutdown processes.Enhancements to Ethernet Configuration:
_eth_started,_link_speed,_full_duplex, and_auto_negotiationto theETHClassto store Ethernet configuration settings.setFullDuplex,setLinkSpeed, andsetAutoNegotiationto allow configuration of Ethernet settings before callingETH.begin(). Each method includes validation to ensure settings are applied correctly. [1] [2] [3]_setFullDuplex,_setLinkSpeed, and_setAutoNegotiationto apply the settings to the Ethernet hardware.Initialization and Shutdown Process:
ETHClass::beginandETHClass::beginSPImethods to apply the Ethernet configuration settings (full duplex, link speed, and auto-negotiation) during the initialization process if auto-negotiation is disabled. [1] [2]ETHClass::endmethod to reset the_eth_startedflag when shutting down the Ethernet interface.Code Refactoring:
ETHClassconstructor to initialize the new member variables._eth_startedflag is set to true after successful initialization and set to false during shutdown. [1] [2] [3]Reference: #10923