LwipIntfDev - static IP config for eth interfaces #8076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Problem1: The current changes are OK with me. |
Collaborator
|
@JAndrassy Thanks!
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some problems with Ethernet LwIP interfaces static IP configuration. I want to address them in this PR, but I need directions.
I tested the Ethernet interfaces for W5500 and ENC28j60 with WiFi off and eth.setDefault().
Problem one: DNS setting was not applied. The first commit in this PR has a commit with a proposal how to fix it. Additionally I added default value for dns parameters in
config.Problem two: static config only works if eth.config is followed by eth.setDefault(). I am new to LwIP. Maybe eth.config should have
netif_set_up?