Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Update semver package #246

Merged
merged 1 commit into from
May 2, 2017
Merged

Update semver package #246

merged 1 commit into from
May 2, 2017

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented May 2, 2017

No description provided.

@eslintbot
Copy link

Thanks for the pull request, @SimenB! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@eslintbot
Copy link

Thanks for the pull request, @SimenB! I took a look to make sure it's ready for merging and found some changes are needed:

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@soda0289
Copy link
Member

soda0289 commented May 2, 2017

Can you prefix the commit message with Chore: .

@SimenB
Copy link
Contributor Author

SimenB commented May 2, 2017

@soda0289 Went for Upgrade.

image

Want me to change it?

@soda0289
Copy link
Member

soda0289 commented May 2, 2017

That's fine.
We should probably remove the need for every PR to depend on an issue. You can just ignore the bot.

@soda0289 soda0289 merged commit 2989f8b into eslint:master May 2, 2017
@SimenB SimenB deleted the update-semver branch May 2, 2017 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants