Skip to content

feat!: drop node<18 #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2025
Merged

feat!: drop node<18 #77

merged 1 commit into from
Sep 22, 2025

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Sep 18, 2025 •
edited
Loading

Prerequisites checklist

What is the purpose of this pull request?

Node<18 has been EOL for several years, it's time to drop support for them.

What changes did you make? (Give an overview)

Node version support aligns with ESLint v9.

Related Issues

Is there anything you'd like reviewers to focus on?

⚠️we might need to double-check the node version running on the Jenkins server.

@eslintbot eslintbot added this to Triage Sep 18, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Sep 18, 2025
@aladdin-add aladdin-add moved this from Needs Triage to Implementing in Triage Sep 18, 2025
@aladdin-add aladdin-add mentioned this pull request Sep 18, 2025
Merged
1 task
@mdjermanovic
Copy link
Member

⚠️we might need to double-check the node version running on the Jenkins server.

Currently, v20.9.0.

mdjermanovic
mdjermanovic approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Would like @nzakas and @fasttime to confirm that we want to drop Node < 18 for this package, and verify the changes.

@mdjermanovic mdjermanovic moved this from Implementing to Second Review Needed in Triage Sep 18, 2025
lumirlumir
lumirlumir approved these changes Sep 20, 2025
View reviewed changes
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime
Copy link
Member

Would like @nzakas and @fasttime to confirm that we want to drop Node < 18 for this package, and verify the changes.

If there's no need to go back to Node.js 18 (which I hope), then I think it's fine to drop support 👍

fasttime
fasttime approved these changes Sep 21, 2025
View reviewed changes
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

nzakas
nzakas approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Considering we're the only ones using this package, we can pretty much do what we want. 😄

@nzakas nzakas merged commit 6718129 into main Sep 22, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nzakas nzakas nzakas approved these changes

@fasttime fasttime fasttime approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

@lumirlumir lumirlumir lumirlumir approved these changes

Assignees

No one assigned

Labels

breaking feature

Projects

Triage
Status: Complete

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aladdin-add @mdjermanovic @fasttime @nzakas @lumirlumir