-
-
Notifications
You must be signed in to change notification settings - Fork 10
chore(docs): remove eslint4b
#19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
/* globals window */ | ||
export default () => { | ||
if (typeof window !== "undefined") { | ||
if (typeof window.process === "undefined") { | ||
window.process = { | ||
cwd: () => undefined, | ||
} | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,16 +24,16 @@ | |
"@vuepress/plugin-pwa": "^1.9.9", | ||
"cross-spawn": "^7.0.3", | ||
"eslint": "^8.46.0", | ||
"eslint4b": "^7.32.0", | ||
"fs-extra": "^10.1.0", | ||
"mocha": "^9.2.2", | ||
"nyc": "^15.1.0", | ||
"opener": "^1.5.2", | ||
"rimraf": "^3.0.2", | ||
"semver": "^7.5.4", | ||
"string-replace-loader": "^3.1.0", | ||
"string-replace-loader": "^2.3.0", | ||
"vue-eslint-editor": "^1.1.0", | ||
"vuepress": "^1.9.9" | ||
"vuepress": "^1.9.9", | ||
"webpack": "^4.47.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added it because some dependencies were updated and without it webpack v5 would be used and broken. I think we need to move away from vuepress later. (I would like to replace it with vitepress when I have time) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I opened a PR that uses vitepress. #114 |
||
}, | ||
"scripts": { | ||
"preversion": "npm test", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why we're downgrading here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like v4 has been deleted.
codecov/codecov-action#1089