chore(docs): remove eslint4b
#19
Conversation
|
This PR has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from PRs that aren't actionable. Please reach out if you have more information for us! 🙂 |
|
@ota-meshi I guess this one can be rebased now 🤔 |
|
I'm busy with office work and other OSS maintenance, so I'll work on it when I have time 😅 |
ota-meshi
force-pushed
the
eslint-v8-demo
branch
from
f4fb8f9 to
6333e90
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
=======================================
Coverage 97.87% 97.87%
=======================================
Files 17 17
Lines 282 282
=======================================
Hits 276 276
Misses 6 6 ☔ View full report in Codecov by Sentry. |
| "vue-eslint-editor": "^1.1.0", | ||
| "vuepress": "^1.9.9" | ||
| "vuepress": "^1.9.9", | ||
| "webpack": "^4.47.0" |
There was a problem hiding this comment.
I added it because some dependencies were updated and without it webpack v5 would be used and broken.
I think we need to move away from vuepress later. (I would like to replace it with vitepress when I have time)
There was a problem hiding this comment.
I opened a PR that uses vitepress. #114
|
@MichaelDeBoey Sorry for the delay. I rebased this PR and fixed it to work. |
| @@ -85,7 +85,7 @@ jobs: | |||
| run: npm run test | |||
|
|
|||
| - name: ⬆️ Upload coverage report | |||
| uses: codecov/codecov-action@v4 | |||
| uses: codecov/codecov-action@v3 | |||
There was a problem hiding this comment.
Is there a reason why we're downgrading here?
There was a problem hiding this comment.
It looks like v4 has been deleted.
codecov/codecov-action#1089
MichaelDeBoey
changed the title
eslint4b
This PR removes eslint4b from dev dependencies.
Also change eslint in dev dependencies to v8. But we get an error when linting. This is because
@mysticatea/eslint-plugindoes not support eslint v8. We need to replace it with theeslint-communitypackage first.#20 is a PR that solves dependency issues.