Skip to content

Make poll() test work with gcc 14 #9212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make poll() test work with gcc 14 #9212

wants to merge 1 commit into from

Conversation

@lukebakken
Copy link
Contributor

@lukebakken lukebakken commented Dec 17, 2024 •
edited
Loading

Fixes #9211

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

CT Test Results

    3 files    141 suites   48m 46s ⏱️
1 598 tests 1 548 ✅ 49 💤 1 ❌
2 307 runs  2 237 ✅ 69 💤 1 ❌

For more details on these failures, see this check.

Results for commit e2604aa.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@lukebakken lukebakken mentioned this pull request Dec 17, 2024
Closed
@lukebakken lukebakken force-pushed the lukebakken/erlang-otp-9211 branch from 5281e69 to b7d7c94 Compare December 17, 2024 22:15
lukebakken
lukebakken commented Dec 17, 2024
View reviewed changes
@lukebakken lukebakken marked this pull request as ready for review December 17, 2024 22:16
@lukebakken lukebakken force-pushed the lukebakken/erlang-otp-9211 branch from b7d7c94 to c0a4870 Compare December 18, 2024 20:02
@IngelaAndin IngelaAndin added the team:VM Assigned to OTP team VM label Dec 19, 2024
@mikpe
Copy link
Contributor

mikpe commented Dec 21, 2024

It would be nice to get this backported to maint-27 and maint-26, otherwise I'll almost certainly have to do so locally. The commit in this PR (without the bogus FLOAT16 bits) cherry-picks cleanly on 27 and 26.

@lukebakken lukebakken force-pushed the lukebakken/erlang-otp-9211 branch from c0a4870 to 5a467c6 Compare December 22, 2024 20:27
@lukebakken
Make poll() test work with gcc 14
e2604aa 
Fixes erlang#9211

* Add headers (`stdlib.h`, `fcntl.h`) for `poll`
* Add `unistd.h` for `sbrk`
@lukebakken lukebakken force-pushed the lukebakken/erlang-otp-9211 branch from 5a467c6 to e2604aa Compare December 22, 2024 20:30
@lukebakken
Copy link
Contributor Author

@mikpe done. I rebased this PR on master and the float 16 changes are gone. See the following PRs with back-ports:

@mikpe
Copy link
Contributor

mikpe commented Dec 22, 2024

Thanks @lukebakken

@tianon tianon mentioned this pull request Jan 7, 2025
Merged
@JimMoen JimMoen mentioned this pull request Jan 8, 2025
Closed
@jhogberg jhogberg self-assigned this Jan 8, 2025
@jhogberg
Copy link
Contributor

Merged as #9234 :-)

@jhogberg jhogberg closed this Jan 10, 2025
@lukebakken lukebakken deleted the lukebakken/erlang-otp-9211 branch February 12, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickard-green rickard-green rickard-green left review comments

Assignees

@jhogberg jhogberg

Labels

team:VM Assigned to OTP team VM

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

erts/configure does not detect poll() correctly when gcc 14 is used

5 participants

@lukebakken @mikpe @jhogberg @rickard-green @IngelaAndin