Skip to content

Watch Created with Empty Resource Names #411

@minwoox

Description

@minwoox

According to the Envoy xDS protocol documentation:

If the list of resource names becomes empty, that means the client is no longer interested in any resources of the specified type.

However, the DiscoveryRequestStreamObserver currently creates a new watch even when the resource names list becomes empty, which violates the spec.
https://github.com/envoyproxy/java-control-plane/blob/main/server/src/main/java/io/envoyproxy/controlplane/server/DiscoveryRequestStreamObserver.java#L80-L94

I think we can just cancel the previous watch and not create another one in this case. Please let me know if this makes sense, and I’ll be happy to submit a PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions