build: fix eslint issues #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enuchi
reviewed
Apr 4, 2022
|
Thanks for opening this @noomorph. You're right, it's hard to keep this up to date. The main issue is some of the webpack plugins needed are not maintained so it's not easy to move to webpack 5. @kmalakoff has an open PR for this but have not had a chance to look (#103). Thanks for pinning the .nvmrc file -- ideally should be v16. Do you know what kind of errors it was showing? |
|
@enuchi looks like it comes from
|
|
Okay, I found the reason. Upgrading to |
|
Thanks for the work on this @noomorph, much appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to run ESLint of files due to various errors:
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './lib/util/glob-util' is not defined by "exports"Failed to load plugin 'import' declared in '.eslintrc » eslint-config-airbnbrequire() of ES modules is not supported" when package.json has "type":"module"After a battle with dependencies and configs,
package-lock.jsonand so on, I also noticed a few issues around the code itself, and fixed them too.That's the result.
Thanks for the project. Honestly, it feels like you don't have time to keep it up-to-date, but anyway it still looks like the best out-of-the-box solution currently on GitHub.
P. S. I had to lock
.nvmrcto Node 14.x, in fact. When running with Node 16.x, I see too many errors – so I'd suggest you to review that separately if you'd like to unlock it further.