This repository was archived by the owner on Sep 21, 2019. It is now read-only.
WIP - Add :EnRestart command
#350
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New command to restart ensime servers without leaving the Vim session
ktonga
force-pushed
the
server-restart
branch
from
da4b362 to
ef5a536
Compare
jvican
approved these changes
Dec 30, 2016
|
@jvican, yes, i did, sadly it's not working. Something related to the threading system is not working as I expected, as a result it doesn't execute the shutdown sequence of steps in the order the should be executed. That's why I tagged this PR as a WIP. |
|
Cool, hope to see this feature soon. In my opinion, it's one of the most important ones. Spurious errors happen in the communication between client and servers and being able to restart the connection is a huge improvement in UX. We also need to figure out what's going on under the hood with the connection. Stability and predictability should be a primer concern for us 🥇 I don't know whether you guys agree on this. |
This was referenced Jan 3, 2017
ches
referenced
this pull request
in ches/ensime-vim
Jan 7, 2017
Killing the server doesn't completely lead to everything restarting yet, but it's almost there. Might leave the rest to @ktonga on #350. Generally it's supposed to be an invariant that if client's self.connected is true, then self.ws should be set--so use that everywhere instead of having a mix that's confusing.
ches
referenced
this pull request
in ches/ensime-vim
Jan 13, 2017
Killing the server doesn't completely lead to everything restarting yet, but it's almost there. Might leave the rest to @ktonga on #350. Generally it's supposed to be an invariant that if client's self.connected is true, then self.ws should be set--so use that everywhere instead of having a mix that's confusing.
ches
referenced
this pull request
in ches/ensime-vim
Aug 26, 2017
Killing the server doesn't completely lead to everything restarting yet, but it's almost there. Might leave the rest to @ktonga on #350. Generally it's supposed to be an invariant that if client's self.connected is true, then self.ws should be set--so use that everywhere instead of having a mix that's confusing.
ches
referenced
this pull request
in ches/ensime-vim
Aug 26, 2017
Killing the server doesn't completely lead to everything restarting yet, but it's almost there. Might leave the rest to @ktonga on #350. Generally it's supposed to be an invariant that if client's self.connected is true, then self.ws should be set--so use that everywhere instead of having a mix that's confusing.
ches
referenced
this pull request
in ches/ensime-vim
Aug 27, 2017
Killing the server doesn't completely lead to everything restarting yet, but it's almost there. Might leave the rest to @ktonga on #350. Generally it's supposed to be an invariant that if client's self.connected is true, then self.ws should be set--so use that everywhere instead of having a mix that's confusing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a work in progress only shared to get some early feedback, not ready to be merged yet. Still trying to fix a problem that prevents it to work properly.
There's a few logging lines to debug the problem, please ignore them by now.