Switch property labels back to human readable #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbnicholson
approved these changes
Nov 4, 2024
Member
dbnicholson
left a comment
dbnicholson
left a comment
There was a problem hiding this comment.
I think that makes sense after reading that capitalize is more like a conversion to a sentence.
Contributor
Author
Yes, it's not like Python's capitalize which makes the first character upper case and the rest lower-case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit c18ab3f we regressed the property names from capitalized to lower case. We actually want both: capitalize them and then lower case them.
Fixes #302