blocks: Remove extra newlines from entry blocks #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Funny, the tests are asserting that the ugly newlines are present... |
Member
Author
Whoops! Forgot to check the tests... |
Entry blocks already add a trailing newline, so there's no need to include one in the code template. See the ready, process and define_method blocks, for example. Having one doesn't cause any harm, but it does make the generated code uglier.
dbnicholson
force-pushed
the
extra-newlines
branch
from
af12f93 to
851e5f7
Compare
wjt
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entry blocks already add a trailing newline, so there's no need to include one in the code template. See the ready, process and define_method blocks, for example. Having one doesn't cause any harm, but it does make the generated code uglier.