Zoom in and out buttons #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoomTas3r
force-pushed
the
zoom-in-and-out-buttons
branch
from
750b7f2 to
09977d1
Compare
manuq
requested changes
Oct 21, 2024
Contributor
manuq
left a comment
manuq
left a comment
There was a problem hiding this comment.
This is a great contribution! Only one thing requested: the buttons should contain icons, not text.
| layout_mode = 2 | ||
| focus_mode = 0 | ||
| theme_override_font_sizes/font_size = 24 | ||
| text = "-" |
Contributor
There was a problem hiding this comment.
This should be an icon button. The Godot editor has icons for zoom less / more:
| layout_mode = 2 | ||
| focus_mode = 0 | ||
| theme_override_font_sizes/font_size = 24 | ||
| text = "+" |
Contributor
There was a problem hiding this comment.
Same here, it should be an icon button.
manuq
approved these changes
Oct 21, 2024
Contributor
manuq
left a comment
manuq
left a comment
There was a problem hiding this comment.
With the icons this is excellent now! Please squash the commits and add a descriptive commit message.
Here is a good article about writting good commmit messages: https://dhwthompson.com/2019/my-favourite-git-commit
|
|
||
| func _on_zoom_out_button_pressed() -> void: | ||
| if zoom > 0.2: | ||
| zoom /= ZOOM_FACTOR |
Proper input options are necessary for each platform, especially when the interface primarily utilizes point-and-click input
DoomTas3r
force-pushed
the
zoom-in-and-out-buttons
branch
from
f48bd11 to
7ac9caa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds zoom in and out buttons for touch input devices
