Skip to content

Revert "Fix NamespaceVersioning ignoring DEFAULT_VERSION on non-None namespaces" #9335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2024
Merged

Revert "Fix NamespaceVersioning ignoring DEFAULT_VERSION on non-None namespaces" #9335

merged 1 commit into from
Mar 22, 2024

Conversation

auvipy
Copy link
Contributor

@auvipy auvipy commented Mar 22, 2024 •
edited by lovelydinosaur
Loading

Reverts #7278

Closes #9334

@auvipy auvipy mentioned this pull request Mar 22, 2024
Closed
@lovelydinosaur lovelydinosaur merged commit 400b4c5 into master Mar 22, 2024
@lovelydinosaur lovelydinosaur deleted the revert-7278-fix-namespace-versioning branch March 22, 2024 09:39
@lovelydinosaur lovelydinosaur mentioned this pull request Mar 22, 2024
Closed
9 tasks
@Kostia-K
Copy link
Contributor

Kostia-K commented Mar 22, 2024 •
edited
Loading

Wait, is this bugfiix going to come back in the next version?
I wrote a comment why I think it shouldn't be reverted, can you please take a look #9334 (comment)?

@lovelydinosaur
Copy link
Collaborator

You'd be very welcome to raise a discussion and talk the proposal through, yes.
At this point in time, we clearly needed to prioritise rolling this back (along with various other behavioural changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3.15 regression: Unset default namespace version suddenly raises 404
3 participants
@auvipy @Kostia-K @lovelydinosaur