refactor removing parameters from kwargs when creating a ListSerializer #9245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MOHAMMEDSAGHEER95
approved these changes
Jan 30, 2024
math-a3k
approved these changes
Jan 30, 2024
Contributor
math-a3k
left a comment
math-a3k
left a comment
There was a problem hiding this comment.
It does seem like an improvement in the code readability to me
auvipy
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When constructing a serializer with
many=True, it constructs aListSerializer. In order to do this, it first pops certain kwargs that are then injected in theListSerializerconstructor, and not that of the subfield.In order to make it more elegant, and dry, the fields are moved to a tuple, and it thus works with a loop to process it.