Build embind/fetch/etc as system libraries rather than compile-on-demand during linking #8817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantum5
reviewed
Jun 18, 2019
sbc100
force-pushed
the
embind_as_library
branch
from
c5118d3 to
99fad63
Compare
quantum5
approved these changes
Jun 18, 2019
sbc100
force-pushed
the
embind_as_library
branch
from
99fad63 to
45f9740
Compare
sbc100
changed the title
sbc100
force-pushed
the
embind_as_library
branch
from
385c7b9 to
6d64353
Compare
quantum5
reviewed
Jun 19, 2019
sbc100
force-pushed
the
embind_as_library
branch
from
6d64353 to
72cf0e8
Compare
…and during linking
sbc100
force-pushed
the
embind_as_library
branch
from
72cf0e8 to
d04c8ec
Compare
|
ping @sbc100 about this regression |
sbc100
added a commit
that referenced
this pull request
Aug 16, 2019
This is partial revert of #8817. It turns out that all users of bind.h have to agree on -fno-rtti. In particular if a user passed -fno-rtti to build their code the bind.cpp needs to be compiled with the same settings. Perhaps we can find a way to avoid this in the future but for now it looks like we are stuck compiling bind.cpp on demand at link time. Fixes: #9122
sbc100
added a commit
that referenced
this pull request
Aug 16, 2019
This is partial revert of #8817. It turns out that all users of bind.h have to agree on -fno-rtti. In particular if a user passed -fno-rtti to build their code the bind.cpp needs to be compiled with the same settings. Perhaps we can find a way to avoid this in the future but for now it looks like we are stuck compiling bind.cpp on demand at link time. Fixes: #9122
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that we can build it in advance and cache it and avoids
needing to pass compile flags at link time.
Internally at google we separate the compilation and linking phases such
that the compiler isn't even necessarily available during linking.