Skip to content

Conversation

@saschanaz
Copy link
Collaborator

Remove bindings_generator (with CppHeaderParser), demangler, and namespacer.

@kripken
Copy link
Member

kripken commented Nov 13, 2017

lgtm, thanks.

The other.test_stdin was an existing error meanwhile fixed on incoming, I believe?

I think we can also remove tools/third_party/gcc_demangler.js (but not the .c, it's used in a test)

@saschanaz
Copy link
Collaborator Author

saschanaz commented Nov 14, 2017

The other.test_stdin was an existing error meanwhile fixed on incoming, I believe?

A closure error, so it must be.

I think we can also remove tools/third_party/gcc_demangler.js (but not the .c, it's used in a test)

It's test_gcc_unmangler but do we even need it?

@kripken
Copy link
Member

kripken commented Nov 14, 2017

The gcc unmangler test itself? Yes, it's a useful test I think, it's kind of weird C code, good for coverage.

@kripken kripken merged commit 0ab9923 into emscripten-core:incoming Nov 14, 2017
sbc100 added a commit that referenced this pull request Oct 9, 2020
It looks like support for PREAMBLE_ADDITIONS was removed
in #5739 and MODULE_ADDITIONS in #5773.
sbc100 added a commit that referenced this pull request Oct 9, 2020
It looks like support for PREAMBLE_ADDITIONS was removed
in #5739 and MODULE_ADDITIONS in #5773.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants