webgl2_texture_fixes #4892
Merged
webgl2_texture_fixes #4892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
lgtm |
…fer to their entrypoints. Fix GL_PIXEL_PACK_BUFFER and GL_PIXEL_UNPACK_BUFFER to be taken into account when operating with texture functions. Use fast garbage free WebGL 2 entry points for texture functions.
juj
force-pushed
the
webgl2_texture_fixes
branch
from
b29cadf to
de80d09
Compare
Collaborator
Author
|
Tested out in browser suite and in action, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix glTexImage3D and glTexSubImage3D to pass correct type of arraybuffer to their entrypoints. Fix GL_PIXEL_PACK_BUFFER and GL_PIXEL_UNPACK_BUFFER to be taken into account when operating with texture functions. Use fast garbage free WebGL 2 entry points for texture functions.