Skip to content

Conversation

shreyas-omkar
Copy link

@shreyas-omkar shreyas-omkar commented Oct 19, 2025

Add a CSS class to the main parent div of the memory profiler UI.

Currently, the profiler's container div is created with no ID or class, making it impossible to target with CSS. This is problematic for developers (like in the original issue) who run their application in full-screen, as the profiler UI gets hidden with no way to adjust its z-index.

This change adds the class emscripten-memory-profiler-container to the div upon its creation in library_memoryprofiler.js.

This allows developers to easily style the profiler. For example:

<style>
  .emscripten-memory-profiler-container {
    z-index: 9999;
  }
</style>

Fixes: #20115

@shreyas-omkar shreyas-omkar force-pushed the fix/memory-profiler-class branch from d6d2bfd to 10a690f Compare October 19, 2025 20:29
@shreyas-omkar
Copy link
Author

@sbc100 Please review the changes.

@shreyas-omkar
Copy link
Author

Sure I will.

@shreyas-omkar shreyas-omkar force-pushed the fix/memory-profiler-class branch from 10a690f to ff9f41e Compare October 20, 2025 07:47
@shreyas-omkar
Copy link
Author

Hi @sbc100 I have removed the ChangeLog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

memoryprofiler parent div doesn't have a class

2 participants