Merge assignWasmExports and assignWasmSymbols. NFC #25592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
juj
reviewed
Oct 20, 2025
juj
approved these changes
Oct 20, 2025
sbc100
force-pushed
the
assignWasmExports
branch
from
a1d2aab to
b193790
Compare
These two functions serve exactly the same purpose so just make them into a single function. There are still two different methods by which this gets defined but from the POV of the caller they are the same thing.
sbc100
force-pushed
the
assignWasmExports
branch
from
b193790 to
658da31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two functions serve exactly the same purpose so just make them into a single function.
There are still two different methods by which this gets defined but from the POV of the caller they are the same thing.