Fix shlex splitting when launching parallel browser test runner on Windows. #25222
Conversation
|
|
||
| @staticmethod | ||
| def data_dir_cmdline(data_dir): | ||
| return ['-profile', data_dir] |
There was a problem hiding this comment.
Does chrome not support ['--user-data-dir', xxx] or firefox not support -profile=foo? i.e. can we use the same method for both?
There was a problem hiding this comment.
Firefox at least does not support -profile=foo, but silently ignores it.
I don't have Chrome set up to test.
There was a problem hiding this comment.
lgtm then, but lets lets @brendandahl approve since he wrote this code.
|
This change seems to have broken a bunch of the |
|
I can't see why though.. the command line before and after looks identical |
|
Oh, its because |
|
I think maybe we should revert this to make the CI green again. It should be easy enough to re-land. Unless somehow has a fix ready? |
…er on Windows." (#25229) This broken the chrome tests in CI because `--use-gl=swiftshader` is no longer part of `EMTEST_BROWSER` so `no_swiftshader` doesn't work and log of the cubegeom tests are therefore failing. It should be easy enough to re-land, but we need to consider how to make the effects of `EMTEST_BROWSER_AUTO_CONFIG` visible in places like `no_swiftshader`. Reverts #25222
3 participants
Fix shlex splitting when launching parallel browser test runner on Windows.
Before this PR, running
would fail with the parallel test harness attempting to launch browser command line
["C:\Program Files\Mozilla Firefox\firefox.exe -profile C:\emsdk\emscripten\main\out\profile-1"]when it should instead have attempted to launch command line
["C:\Program Files\Mozilla Firefox\firefox.exe", "-profile", "C:\emsdk\emscripten\main\out\profile-1"]Fix by having the browser config first do the shlex stuff to interpret
EMTEST_BROWSER, and only then append the list of strings of command line args, rather than first append the command line args as a string spaghetti, and using shlex split to parse the resulting command line string.