Fix asynchronous GLUT main loop utilizing tests that raced against reftest XHR. #24575
Conversation
| // This test kicks off an asynchronous glutMainLoop(), so do not perform a synchronous | ||
| // reftest immediately after falling out from main. | ||
| EM_ASM({reftestBlock()}); | ||
| #endif |
There was a problem hiding this comment.
Is this change is needed then how/why is this test passing today? I would assume the reftest is triggered by the first swapbuffers or something like that.. but I can't remember now?
There was a problem hiding this comment.
The reftest is triggered in Module'postRun'.
It probably passes because rAF() takes only 16 msecs, and XHRs from disk are likely slower than that, so one or more of rAF()s squeeze in to finish before the XHR completes.
There was a problem hiding this comment.
Perhaps reftest its triggers both by postRun and also by intercepting window.requestAnimationFrame. Perhaps we should have some kind of way to tell the reftest code to wait for RAF instead of also running as part of postRun?
Or perhaps we can/should replace postRun with onExit (which wont' be called when main returns but only when the whole program exits)?
No description provided.