Remove/fix usage of MIN_SAFARI_VERSION #24423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @cwoffenden who authors the check with the hex value. |
We don't support targeting safari version older than 10.10.00 so two of these conditions were always true. The third check was added in emscripten-core#21428 and looks to me like it was always wrong. The window.orientation API was added in safari 16.4 as the comment says so I updated the check to match. I'm not sure where the old value of 0x100400 came from or what it means.
That is odd, but since it’s passed on the command-line it probably worked during testing. It should be 160400, at a glance. |
Right, but presumably not 0x160400 which would be 1442816. Looks like some confusion somewhere (I hope). |
The docs say MMmmVV (something like that, from memory), it’s pretty clear, I don’t know where I made up the hex from. |
kripken
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't support targeting safari version older than 10.10.00 so two of these conditions were always true.
The third check was added in #21428 and looks to me like it was always wrong. The window.orientation API was added in safari 16.4 as the comment says so I updated the check to match. I'm not sure where the old value of 0x100400 came from or what it means.