Skip to content

Remove polyfills for Fetch and Object.assign #23118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Dec 10, 2024

This change required the minimum supported browser versions to be bumped just a little.

@sbc100
Copy link
Collaborator Author

sbc100 commented Dec 10, 2024

@kripken @dschuff WDYT about bumping the min browser versions a little more for this release?

@sbc100 sbc100 force-pushed the remove_fetch_polyfill branch 2 times, most recently from 14018a6 to 71ab969 Compare December 10, 2024 05:32
@sbc100 sbc100 changed the title Remove fetch polyfill Remove polyfills for Fetch and Object.assign Dec 10, 2024
@sbc100 sbc100 requested review from kripken and dschuff December 10, 2024 05:33
@sbc100 sbc100 force-pushed the remove_fetch_polyfill branch from 71ab969 to 5d99050 Compare December 10, 2024 05:34
@dschuff
Copy link
Member

dschuff commented Dec 10, 2024

I guess the question is what do we lose from dropping these. People wanting to target really old browsers will either have to bundle their own versions of these polyfills (short term) and in the long term there may be other things that we drop support for (although since we don't actually test on those browser versions, there could be other things we depend on that we aren't aware of). If someone is targeting those old browsers today and is unable to update emscripten anymore, what do they lose? most of the work on emscripten these days is targeting modern development (new Wasm features, modern tooling, etc). It doesn't seem too likely that they would benefit from much of that work anyway. And 8 years is still pretty good. I think I'm OK with this.

@sbc100
Copy link
Collaborator Author

sbc100 commented Dec 10, 2024

I guess the question is what do we lose from dropping these. People wanting to target really old browsers will either have to bundle their own versions of these polyfills (short term) and in the long term there may be other things that we drop support for (although since we don't actually test on those browser versions, there could be other things we depend on that we aren't aware of).

Yes, there are many other tools out there than can bundle JS for very old browsers and supply pollyfils for the very long tail of users who are targeting 10 year old browsers, but honestly I'm not sure sure if there are any such emscripten users. Perhaps I'll send a message the mailing list to see any anyone responds.

If someone is targeting those old browsers today and is unable to update emscripten anymore, what do they lose? most of the work on emscripten these days is targeting modern development (new Wasm features, modern tooling, etc). It doesn't seem too likely that they would benefit from much of that work anyway. And 8 years is still pretty good. I think I'm OK with this.

@sbc100 sbc100 force-pushed the remove_fetch_polyfill branch from 5d99050 to 705f022 Compare December 10, 2024 17:36
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm unless we get feedback on the mailing list or bluesky with a use case that justifies keeping this

@sbc100 sbc100 force-pushed the remove_fetch_polyfill branch 2 times, most recently from 694e148 to c7bfbd8 Compare December 10, 2024 23:23
This change required the minimum supported browser versions to be
bumped just a little.
@sbc100 sbc100 force-pushed the remove_fetch_polyfill branch from c7bfbd8 to c0505bd Compare December 13, 2024 00:57
@sbc100 sbc100 merged commit 53c8132 into emscripten-core:main Dec 13, 2024
1 of 13 checks passed
@sbc100 sbc100 deleted the remove_fetch_polyfill branch December 13, 2024 00:57
sbc100 added a commit to sbc100/emscripten that referenced this pull request Dec 14, 2024
As of emscripten-core#23118 we can assume and browser and worker environments always
include `fetch`.
sbc100 added a commit to sbc100/emscripten that referenced this pull request Dec 14, 2024
As of emscripten-core#23118 we can assume and browser and worker environments always
include `fetch`.
sbc100 added a commit to sbc100/emscripten that referenced this pull request Dec 16, 2024
As of emscripten-core#23118 we can assume and browser and worker environments always
include `fetch`.
sbc100 added a commit that referenced this pull request Dec 16, 2024
As of #23118 we can assume and browser and worker environments always
include `fetch`.
hedwigz pushed a commit to hedwigz/emscripten that referenced this pull request Dec 18, 2024
This change required the minimum supported browser versions to be bumped
just a little.
hedwigz pushed a commit to hedwigz/emscripten that referenced this pull request Dec 18, 2024
…n-core#23166)

As of emscripten-core#23118 we can assume and browser and worker environments always
include `fetch`.
sbc100 added a commit to sbc100/emscripten that referenced this pull request Dec 30, 2024
sbc100 added a commit to sbc100/emscripten that referenced this pull request Dec 30, 2024
sbc100 added a commit that referenced this pull request Dec 30, 2024
These were changed in #23077 and #23118 but the docs were not updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants