-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Remove polyfills for Fetch and Object.assign #23118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
14018a6
to
71ab969
Compare
71ab969
to
5d99050
Compare
I guess the question is what do we lose from dropping these. People wanting to target really old browsers will either have to bundle their own versions of these polyfills (short term) and in the long term there may be other things that we drop support for (although since we don't actually test on those browser versions, there could be other things we depend on that we aren't aware of). If someone is targeting those old browsers today and is unable to update emscripten anymore, what do they lose? most of the work on emscripten these days is targeting modern development (new Wasm features, modern tooling, etc). It doesn't seem too likely that they would benefit from much of that work anyway. And 8 years is still pretty good. I think I'm OK with this. |
Yes, there are many other tools out there than can bundle JS for very old browsers and supply pollyfils for the very long tail of users who are targeting 10 year old browsers, but honestly I'm not sure sure if there are any such emscripten users. Perhaps I'll send a message the mailing list to see any anyone responds.
|
5d99050
to
705f022
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm unless we get feedback on the mailing list or bluesky with a use case that justifies keeping this
694e148
to
c7bfbd8
Compare
This change required the minimum supported browser versions to be bumped just a little.
c7bfbd8
to
c0505bd
Compare
As of emscripten-core#23118 we can assume and browser and worker environments always include `fetch`.
As of emscripten-core#23118 we can assume and browser and worker environments always include `fetch`.
As of emscripten-core#23118 we can assume and browser and worker environments always include `fetch`.
This change required the minimum supported browser versions to be bumped just a little.
…n-core#23166) As of emscripten-core#23118 we can assume and browser and worker environments always include `fetch`.
These were changed in emscripten-core#23077 and emscripten-core#23118 but the docs were not updated.
These were changed in emscripten-core#23077 and emscripten-core#23118 but the docs were not updated.
This change required the minimum supported browser versions to be bumped just a little.