Skip to content

Bump minimum supported chrome version from 32 to 33 #23077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Dec 4, 2024

This allows us to remove the promise polyfill: https://caniuse.com/promises

@sbc100 sbc100 requested review from brendandahl and kripken December 4, 2024 23:13
@sbc100 sbc100 force-pushed the remove_promise_pollyfill branch from edd590c to 2162d17 Compare December 4, 2024 23:21
@kripken
Copy link
Member

kripken commented Dec 4, 2024

Where do you see that 33 is enough?

I can't find 33 on

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise

@sbc100
Copy link
Collaborator Author

sbc100 commented Dec 4, 2024

@sbc100
Copy link
Collaborator Author

sbc100 commented Dec 4, 2024

It looks like 32 had partial support.

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. odd mdn&caniuse disagree, but it is safe to take the higher version i guess

@sbc100 sbc100 force-pushed the remove_promise_pollyfill branch from 2162d17 to 3960fa9 Compare December 4, 2024 23:32
This allows us to remove the promise polyfill.
@sbc100 sbc100 force-pushed the remove_promise_pollyfill branch from 3960fa9 to 6078795 Compare December 5, 2024 00:39
@sbc100 sbc100 merged commit 78c968b into emscripten-core:main Dec 5, 2024
1 of 12 checks passed
@sbc100 sbc100 deleted the remove_promise_pollyfill branch December 5, 2024 00:40
hedwigz pushed a commit to hedwigz/emscripten that referenced this pull request Dec 18, 2024
sbc100 added a commit to sbc100/emscripten that referenced this pull request Dec 30, 2024
sbc100 added a commit to sbc100/emscripten that referenced this pull request Dec 30, 2024
sbc100 added a commit that referenced this pull request Dec 30, 2024
These were changed in #23077 and #23118 but the docs were not updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants