Avoid try/catch in findEventTarget. NFC #22984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed this while reviewing #22959 |
kripken
approved these changes
Nov 21, 2024
I don't think it could have any material effect. |
sbc100
force-pushed
the
findEventTarget
branch
2 times, most recently
from
803d02b to
8fec0e9
Compare
I updated the change so there should be change at all there.. |
Rather than using try/catch to detect when `document` is missing we explicitly check for it. This is the same pattern used in the other version of `findEventTarget` on line 336. This avoids casting a wide net and hiding errors in the rest of the code in this function. Its also more consistent with the other version of `findEventTarget`. One change here is that the fallback for when `querySelector` fails is now the same as the fallback for when `document` is missing. In this case we return `undefined`. Returning a string from findEventTarget is never correct. Its always supposed to return a DOM element AFAICT.
sbc100
force-pushed
the
findEventTarget
branch
from
8fec0e9 to
46fe727
Compare
kripken
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using try/catch to detect when
documentis missing we explicitly check for it. This is the same pattern used in the other version offindEventTargeton line 336.This avoids casting a wide net and hiding errors in the rest of the code in this function. Its also more consistent with the other version of
findEventTarget.