Ignore unknown keyCodes in library_sdl.js #22920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
sdl_keycodes
branch
3 times, most recently
from
96f9ec6 to
17f7fb2
Compare
kripken
reviewed
Nov 14, 2024
kripken
approved these changes
Nov 15, 2024
Prior to this change any unrecognized DOM keyCode would be directly passed through with the DOM keyCode used as an SDL keycode. This strange behavior is what allowed `test_sdl_key_proxy` to use SDL key codes when generating new `KeyboardEvent`s. The number previously hardcoded in the test (1248, 1249, 1250) correspond to (SDLK_LCTRL, SDLK_LSHIFT, SDLK_LALT) but don't make any sense as DOM keyboard codes.
uysalibov
pushed a commit
to uysalibov/emscripten
that referenced
this pull request
Nov 15, 2024
Prior to this change any unrecognized DOM keyCode would be directly passed through with the DOM keyCode used as an SDL keycode. This strange behavior is what allowed `test_sdl_key_proxy` to use SDL key codes when generating new `KeyboardEvent`s. The number previously hardcoded in the test (1248, 1249, 1250) correspond to (SDLK_LCTRL, SDLK_LSHIFT, SDLK_LALT) but don't make any sense as DOM keyboard codes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change any unrecognized DOM keyCode would be directly passed through with the DOM keyCode used as an SDL keycode.
This strange behavior is what allowed
test_sdl_key_proxyto use SDL key codes when generating newKeyboardEvents. The number previously hardcoded in the test (1248, 1249, 1250) correspond to (SDLK_LCTRL, SDLK_LSHIFT, SDLK_LALT) but don't make any sense as DOM keyboard codes.